Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: speed up unmarshall performance #71

Merged
merged 15 commits into from
Oct 4, 2022
Merged

feat: speed up unmarshall performance #71

merged 15 commits into from
Oct 4, 2022

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Oct 3, 2022

Reuse the object to keep processing the stream instead
of creating a new one for each message

7% speed up in unmarshalling performance

5% speed up in processing subsequent messages

bdraco added 3 commits October 3, 2022 12:34
Reuse the object to keep processing the stream instead
of creating a new one for each message
Reuse the object to keep processing the stream instead
of creating a new one for each message
Reuse the object to keep processing the stream instead
of creating a new one for each message
@codecov
Copy link

codecov bot commented Oct 3, 2022

Codecov Report

Base: 81.02% // Head: 81.28% // Increases project coverage by +0.25% 🎉

Coverage data is based on head (95dc97f) compared to base (cccfea3).
Patch coverage: 97.58% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #71      +/-   ##
==========================================
+ Coverage   81.02%   81.28%   +0.25%     
==========================================
  Files          25       25              
  Lines        2899     2928      +29     
  Branches      568      569       +1     
==========================================
+ Hits         2349     2380      +31     
+ Misses        339      338       -1     
+ Partials      211      210       -1     
Impacted Files Coverage Δ
src/dbus_fast/__version__.py 0.00% <0.00%> (ø)
src/dbus_fast/message_bus.py 72.43% <ø> (+0.11%) ⬆️
src/dbus_fast/_private/unmarshaller.py 96.41% <98.03%> (+0.33%) ⬆️
src/dbus_fast/aio/message_bus.py 87.61% <100.00%> (+0.28%) ⬆️
src/dbus_fast/glib/message_bus.py 81.06% <100.00%> (+0.56%) ⬆️
src/dbus_fast/message.py 91.48% <100.00%> (+0.28%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bdraco bdraco marked this pull request as ready for review October 4, 2022 01:11
@bdraco bdraco merged commit f38e08f into main Oct 4, 2022
@bdraco bdraco deleted the unmarshall branch October 4, 2022 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant