Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve unmarshaller performance #360

Closed
wants to merge 3 commits into from
Closed

feat: improve unmarshaller performance #360

wants to merge 3 commits into from

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Jan 10, 2025

Avoid some more dict lookups

Copy link

codecov bot commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.63%. Comparing base (d376bb1) to head (d5e0ebd).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #360      +/-   ##
==========================================
+ Coverage   83.48%   83.63%   +0.14%     
==========================================
  Files          28       28              
  Lines        3354     3354              
  Branches      604      603       -1     
==========================================
+ Hits         2800     2805       +5     
+ Misses        346      341       -5     
  Partials      208      208              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented Jan 10, 2025

CodSpeed Performance Report

Merging #360 will not alter performance

Comparing flags_types (d5e0ebd) with main (d376bb1)

Summary

✅ 3 untouched benchmarks

@bdraco
Copy link
Member Author

bdraco commented Jan 10, 2025

~1%

not worth the change

@bdraco bdraco closed this Jan 10, 2025
@bdraco bdraco deleted the flags_types branch January 10, 2025 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant