validators: allow spaces in dbus property names #329
Conversation
Signed-off-by: Bardia Moshiri <[email protected]>
| @@ -10,7 +10,7 @@ | |||
|
|
|||
| _bus_name_re = re.compile(r"^[A-Za-z_-][A-Za-z0-9_-]*$") | |||
| _path_re = re.compile(r"^[A-Za-z0-9_]+$") | |||
| _element_re = re.compile(r"^[A-Za-z_][A-Za-z0-9_]*$") | |||
| _element_re = re.compile(r"^[A-Za-z_][A-Za-z0-9_ ]*$") | |||
There was a problem hiding this comment.
Can you point out where the spec allows spaces?
It doesn't appear to based on how I'm reading it
https://dbus.freedesktop.org/doc/dbus-specification.html
Each element must only contain the ASCII characters "[A-Z][a-z][0-9]_"
There was a problem hiding this comment.
It looks like even though the spec doesn't allow for this, real-world use cases do require it, which is kinda irritating... The crux of the issue is that we don't want to have to distribute a patched version of dbus-fast to be able to expose interfaces that are compatible with these real-world use cases -- and getting everyone to abide by the spec and do the right thing would be a big undertaking; they could just say "nah not interested in patching this, it works fine for me".
Maybe an alternative solution would be to allow to bypass/replace this validator from user code? That way people can't accidentally disobey the spec but a escape hatch would be available for those who know what they are doing.
There was a problem hiding this comment.
Maybe its OK to accept this change (assuming we also get some tests)
I asked other members to take a look in case there is a security impact I'm not thinking about
pretty self explanatory. dbus property names can have spaces in them (its a legal character), an example is mmsd and all its implementations (mmsd-tng and mmsd4ofono)
https://gitlab.com/kop316/mmsd/-/blob/master/doc/message-api.txt?ref_type=heads#L66
a similar patch was applied to dbus-next for my mmsd4ofono implementation
property:
https://github.com/FuriLabs/mmsd4ofono/blob/trixie/mmsd/ofono_mms_message.py#L97
dbus next patch:
FuriLabs/python-dbus-next@558fdec