fix: messages could be sent out of order if they had to queue #225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The queue should have been read from the left, but it was instead read from the right which meant if the message did not send right away it was LIFO instead of FIFO
The queue should have been read from the left, but it was instead read from the right which meant if the message did not send right away it was LIFO instead of FIFO
bdraco
commented
Aug 17, 2023
The queue should have been read from the left, but it was instead read from the right which meant if the message did not send right away it was LIFO instead of FIFO
The queue should have been read from the left, but it was instead read from the right which meant if the message did not send right away it was LIFO instead of FIFO
The queue should have been read from the left, but it was instead read from the right which meant if the message did not send right away it was LIFO instead of FIFO
bdraco
changed the title
bdraco
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The queue should have been read from the left, but it was instead read from the right which meant if
the message did not send right away it was LIFO instead of FIFO
This went unnoticed because most of the time we can send immediately and it never queues
This probably didn't break anything but it meant that the queue had to empty before code could continue if we awaited the future, and since messages kept getting put in and going out first, it made things more latent than need be