feat: speed up to processing bluez passive data #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a ~5% speed up
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #221 +/- ##
==========================================
+ Coverage 82.67% 82.71% +0.03%
==========================================
Files 27 27
Lines 3221 3240 +19
Branches 668 671 +3
==========================================
+ Hits 2663 2680 +17
Misses 343 343
- Partials 215 217 +2
☔ View full report in Codecov by Sentry. |
This is a ~5% speed up
This is a ~5% speed up
This is a ~5% speed up
This is a ~5% speed up
This is a ~5% speed up
bdraco
force-pushed
the
bluetooth_passive_speed_up
branch
from
d542f25 to
0f1f22d
Compare
bdraco
commented
Aug 9, 2023
Comment on lines
+926
to
+927
| if not _expects_reply(msg): | ||
| return |
There was a problem hiding this comment.
The default was to always call send_reply when a reply wasn't expected it would just be thrown away. All that work for 6500 DeviceFound messages per minute and they are just discarded 🙈
bdraco
changed the title
bdraco
commented
Aug 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Edit: after reviewing test data from multiple systems, this is avg of ~43% speed up
The previous design would create a response message and never send it if no reply was expected. Since the RSSI updates were all generating reply messages and throwing them away it was a significant CPU time use. By not generating the message we speed up getting data from the stream, and since everything has to wait for the data stream to get notifications / new GATT data it speeds up everything bluetooth for local adapters