Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove async_timeout dependency #218

Merged
merged 1 commit into from
Aug 2, 2023
Merged

feat: remove async_timeout dependency #218

merged 1 commit into from
Aug 2, 2023

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Aug 2, 2023

One of the goals here is no required deps. While async_timeout is light, we can get rid of it

@codecov
Copy link

codecov bot commented Aug 2, 2023

Codecov Report

Patch coverage: 75.00% and project coverage change: -0.33% ⚠️

Comparison is base (04d6451) 82.83% compared to head (c0db9db) 82.51%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #218      +/-   ##
==========================================
- Coverage   82.83%   82.51%   -0.33%     
==========================================
  Files          27       27              
  Lines        3222     3220       -2     
  Branches      669      668       -1     
==========================================
- Hits         2669     2657      -12     
- Misses        339      345       +6     
- Partials      214      218       +4     
Files Changed Coverage Δ
src/dbus_fast/__version__.py 0.00% <0.00%> (ø)
src/dbus_fast/aio/message_bus.py 85.57% <100.00%> (-0.14%) ⬇️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco merged commit 7826897 into main Aug 2, 2023
@bdraco bdraco deleted the remove_async_timeout branch August 2, 2023 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant