Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: optimize passive bluez message unmarshaller #216

Merged
merged 1 commit into from
Aug 2, 2023
Merged

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Aug 2, 2023

This is ~3% speed up

@codecov
Copy link

codecov bot commented Aug 2, 2023

Codecov Report

Patch coverage: 91.66% and project coverage change: +0.18% 🎉

Comparison is base (d771bcf) 82.52% compared to head (c6e9b78) 82.71%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #216      +/-   ##
==========================================
+ Coverage   82.52%   82.71%   +0.18%     
==========================================
  Files          27       27              
  Lines        3211     3216       +5     
  Branches      665      666       +1     
==========================================
+ Hits         2650     2660      +10     
+ Misses        343      341       -2     
+ Partials      218      215       -3     
Files Changed Coverage Δ
src/dbus_fast/__version__.py 0.00% <0.00%> (ø)
src/dbus_fast/_private/unmarshaller.py 95.95% <100.00%> (+0.05%) ⬆️
src/dbus_fast/signature.py 62.11% <100.00%> (-0.17%) ⬇️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco
Copy link
Member Author

bdraco commented Aug 2, 2023

All good overnight

@bdraco bdraco marked this pull request as ready for review August 2, 2023 15:36
@bdraco bdraco merged commit e0e87ec into main Aug 2, 2023
@bdraco bdraco deleted the get_signature_tree branch August 2, 2023 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant