Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve performance of reading from the socket during unmarshall #200

Merged
merged 5 commits into from
May 3, 2023

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented May 3, 2023

No description provided.

@codecov
Copy link

codecov bot commented May 3, 2023

Codecov Report

Patch coverage: 75.00% and project coverage change: -0.08 ⚠️

Comparison is base (a17d6d0) 82.31% compared to head (86604bf) 82.23%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #200      +/-   ##
==========================================
- Coverage   82.31%   82.23%   -0.08%     
==========================================
  Files          27       27              
  Lines        3167     3170       +3     
  Branches      654      610      -44     
==========================================
  Hits         2607     2607              
- Misses        343      345       +2     
- Partials      217      218       +1     
Impacted Files Coverage Δ
src/dbus_fast/_private/unmarshaller.py 96.49% <75.00%> (+0.02%) ⬆️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bdraco bdraco marked this pull request as ready for review May 3, 2023 22:20
@bdraco bdraco merged commit e5d355f into main May 3, 2023
@bdraco bdraco deleted the performance branch May 3, 2023 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant