Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add optimized parser for properties changed messages with service data #124

Merged
merged 4 commits into from
Oct 29, 2022

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Oct 29, 2022

This was already well optimized but there were some pyobject conversions we can avoid which is <1%, but its good to have the test coverage.

@codecov
Copy link

codecov bot commented Oct 29, 2022

Codecov Report

Base: 81.76% // Head: 81.76% // No change to project coverage 👍

Coverage data is based on head (0bda83e) compared to base (09822a5).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #124   +/-   ##
=======================================
  Coverage   81.76%   81.76%           
=======================================
  Files          27       27           
  Lines        3087     3087           
  Branches      597      597           
=======================================
  Hits         2524     2524           
  Misses        343      343           
  Partials      220      220           
Impacted Files Coverage Δ
src/dbus_fast/__version__.py 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bdraco bdraco merged commit c8a9452 into main Oct 29, 2022
@bdraco bdraco deleted the service_data_opt branch October 29, 2022 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant