Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: optimize signature readers for most common messages #107

Merged
merged 18 commits into from
Oct 13, 2022

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Oct 13, 2022

  • Add specific paths for the 2 most common message types
  • Drop all the cast complexity as we can do just as well with cython bytearray
  • Works out to ~25% speed up testing on my M1 mac and ~29% speed up on the odroid n2+
  • closes Only two high volume body in the whole stack #106

@codecov
Copy link

codecov bot commented Oct 13, 2022

Codecov Report

Base: 81.52% // Head: 81.19% // Decreases project coverage by -0.33% ⚠️

Coverage data is based on head (7e3408c) compared to base (a4fdda2).
Patch coverage: 89.36% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #107      +/-   ##
==========================================
- Coverage   81.52%   81.19%   -0.34%     
==========================================
  Files          26       26              
  Lines        2994     2988       -6     
  Branches      578      577       -1     
==========================================
- Hits         2441     2426      -15     
- Misses        340      346       +6     
- Partials      213      216       +3     
Impacted Files Coverage Δ
src/dbus_fast/__version__.py 0.00% <0.00%> (ø)
src/dbus_fast/_private/unmarshaller.py 94.86% <91.30%> (-1.67%) ⬇️
src/dbus_fast/glib/message_bus.py 81.14% <0.00%> (-2.05%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bdraco bdraco merged commit d5fb4d9 into main Oct 13, 2022
@bdraco bdraco deleted the signature_readers branch October 13, 2022 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Only two high volume body in the whole stack
1 participant