Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: speed up unpack_variants #105

Merged
merged 1 commit into from
Oct 12, 2022
Merged

feat: speed up unpack_variants #105

merged 1 commit into from
Oct 12, 2022

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Oct 12, 2022

This function needs to only unpack very specific types since the data is coming from the unmarshaller. The isinstance checks are not needed here and a type check is all that is needed. This speeds up the run by 30%

This function needs to only unpack very specific types
since the data is coming from the unmarshaller. The
isinstance checks are not needed here and a type check
is all that is needed.  This speeds up the run by 30%
@codecov
Copy link

codecov bot commented Oct 12, 2022

Codecov Report

Base: 81.42% // Head: 81.52% // Increases project coverage by +0.10% 🎉

Coverage data is based on head (ca1b1d3) compared to base (9fa697d).
Patch coverage: 75.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #105      +/-   ##
==========================================
+ Coverage   81.42%   81.52%   +0.10%     
==========================================
  Files          26       26              
  Lines        2994     2994              
  Branches      578      578              
==========================================
+ Hits         2438     2441       +3     
+ Misses        343      340       -3     
  Partials      213      213              
Impacted Files Coverage Δ
src/dbus_fast/__version__.py 0.00% <0.00%> (ø)
src/dbus_fast/unpack.py 100.00% <100.00%> (ø)
src/dbus_fast/message_bus.py 71.00% <0.00%> (-0.38%) ⬇️
src/dbus_fast/glib/message_bus.py 83.19% <0.00%> (+2.04%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bdraco bdraco marked this pull request as ready for review October 12, 2022 08:03
@bdraco bdraco merged commit a4fdda2 into main Oct 12, 2022
@bdraco bdraco deleted the unpack_variants branch October 12, 2022 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant