feat: add additional typing #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdraco
commented
Oct 10, 2022
| self.flags = ( | ||
| flags if type(flags) is MessageFlag else MessageFlag(bytes([flags])) | ||
| ) | ||
| self.flags = flags if type(flags) is MessageFlag else MessageFlag(flags) |
There was a problem hiding this comment.
This looks like it was actually a bug
Codecov ReportBase: 81.49% // Head: 81.49% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #100 +/- ##
=======================================
Coverage 81.49% 81.49%
=======================================
Files 25 25
Lines 2966 2966
Branches 573 573
=======================================
Hits 2417 2417
Misses 338 338
Partials 211 211
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.