-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Authentication is reading 2 bytes at a time #128
Labels
bug
Something isn't working
Comments
|
we can actually mis align the buffer here since we should only read up to 1 if we have b"BEGIN\r" |
So we should read 1024, and then when we expect |
bdraco
added a commit
that referenced
this issue
Oct 31, 2022
We now try to read a whole line at a time since there is no risk of reading too far ahead given that the spec says: The first octet received by the server after the \r\n of the BEGIN command from the client must be the first octet of the authenticated/encrypted stream of D-Bus messages. Unlike all other commands, the server does not reply to the BEGIN command with an authentication command of its own. After the \r\n of the reply to the command before BEGIN, the next octet received by the client must be the first octet of the authenticated/encrypted stream of D-Bus messages. fixes #128
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The text was updated successfully, but these errors were encountered: