Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DBus UID override #54

Closed
kiwiz opened this issue Mar 26, 2023 · 2 comments
Closed

DBus UID override #54

kiwiz opened this issue Mar 26, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@kiwiz
Copy link

kiwiz commented Mar 26, 2023

Is your feature request related to a problem? Please describe.
I got around to testing home-assistant/core#89925, which includes the dbus-fast changes to override the DBus UID: Bluetooth-Devices/dbus-fast#188 Bluetooth-Devices/dbus-fast#193. I tried adding support for this in bleak via hbldh/bleak#1182. Unfortunately, I didn't realize that bluetooth-adapters also uses dbus-fast:

bus = await MessageBus(bus_type=BusType.SYSTEM).connect()
(which results in bluetooth failing to initialize). For now, I've worked around this locally by just patching dbus-fast's auth.py.

Describe the solution you'd like
Some mechanism for overriding the UID in bluetooth-adapters? I'm not sure what the best strategy is here. BLEAK_DBUS_AUTH_UID already exists. On one hand, it doesn't make sense for this library to depend on that env var. On the other, adding a new env var would require setting both.

Additional context

@kiwiz kiwiz added the enhancement New feature or request label Mar 26, 2023
@bdraco
Copy link
Member

bdraco commented Mar 26, 2023

If you propose a code change/PR for all libaries/apps involved I can probably give you some more constructive feedback.

@bdraco
Copy link
Member

bdraco commented Jan 4, 2024

AFAICT this is complete. Let me know if thats not the case

@bdraco bdraco closed this as completed Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants