Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bank Short Long Spell #164

Merged
merged 30 commits into from
Mar 12, 2024
Merged

Bank Short Long Spell #164

merged 30 commits into from
Mar 12, 2024

Conversation

aviggiano
Copy link
Collaborator

@aviggiano aviggiano commented Mar 5, 2024

Description

  • open a simple long position
  • close a simple long position
  • generalize to create any position from list of strategies
  • check invariants for each opened position
  • add P&L invariants (change price and assess if the position does what it is intended)

Type of change

  • Bug fix
  • New feature
  • Breaking change
  • Dependency changes
  • Code refactor / cleanup
  • Documentation or wording changes
  • Other

Checklist:

  • The diff is legible and has no extraneous changes
  • Complex code has been commented, including external interfaces
  • Tests are included for all code paths
  • The base branch is either main, or there's a description of how to merge

Issue Resolution

@aviggiano aviggiano changed the base branch from main to feat/bank-convex-spell-fork-testing March 5, 2024 20:53
@aviggiano aviggiano changed the title Bank Short Long Spell (WIP) WIP: Bank Short Long Spell Mar 6, 2024
@aviggiano aviggiano requested a review from mario-eth March 11, 2024 20:18
@aviggiano aviggiano changed the title WIP: Bank Short Long Spell Bank Short Long Spell Mar 11, 2024
@aviggiano aviggiano requested a review from 0xSpraggins March 11, 2024 20:18
Copy link
Member

@0xSpraggins 0xSpraggins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Just fix the merge conflict and I think your good to start up on Deployment testing

Copy link
Contributor

@Gornutz Gornutz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aviggiano aviggiano changed the base branch from feat/bank-convex-spell-fork-testing to spearbit-vciso March 12, 2024 13:18
@aviggiano aviggiano merged commit 173c58b into spearbit-vciso Mar 12, 2024
@Gornutz Gornutz deleted the feat/bank-short-long-spell branch April 8, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants