BUG: Fixes issue where any component shape was allowed for ComputeTriangleGeometrySizes #1134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imikejackson
added
bug
nyoungbq
approved these changes
Nov 20, 2024
imikejackson
force-pushed
the
topic/triangle_vol_fixes
branch
from
21ba775
to
cc12c08
Compare
imikejackson
force-pushed
the
topic/triangle_vol_fixes
branch
2 times, most recently
from
a7565c0
to
48cdadc
Compare
…iangleGeometrySizes.cpp Signed-off-by: Michael Jackson <[email protected]>
…t input arrays Signed-off-by: Michael Jackson <[email protected]>
Signed-off-by: Michael Jackson <[email protected]> (cherry picked from commit ca7b027)
Signed-off-by: Michael Jackson <[email protected]> (cherry picked from commit 8c0e521)
…array.
A negative value for the face label when used as an index will cast into an unsigned value
and bad things are going to happen.
Signed-off-by: Michael Jackson <[email protected]>
Signed-off-by: Michael Jackson <[email protected]>
This reverts commit a3b118b.
This reverts commit 10f8fc9.
…utility functions" This reverts commit 9226262.
imikejackson
force-pushed
the
topic/triangle_vol_fixes
branch
from
48cdadc
to
5f4242a
Compare
Signed-off-by: Michael Jackson <[email protected]>
imikejackson
force-pushed
the
topic/triangle_vol_fixes
branch
from
5f4242a
to
edb355f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Rename filter to ComputeTriangleGeomVolumes