Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Types #28

Merged
merged 1 commit into from
Jan 31, 2024
Merged

New Types #28

merged 1 commit into from
Jan 31, 2024

Conversation

iammoonman
Copy link
Contributor

Adds layouts and fields consistent with the Scryfall API as of Jan 2024.

@@ -585,6 +617,8 @@ type CardFace struct {
// This will only be set if the card is not in English.
PrintedName *string `json:"printed_name"`

FlavorName *string `json:"flavor_name,omitempty"`
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was looking through the documented card face object and I don't see this one there. I only see it on the card object. Is the documentation incorrect? Do you happen to have an example card that has a card face with a flavor name?

https://scryfall.com/docs/api/cards#card-face-objects

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm that one seems to not have multiple card faces so it only has the flavor_name on the card object and not on the card face object.

@BlueMonday
Copy link
Owner

Thank you for helping keep the library up to date! Just have one question about one of the new fields!

@BlueMonday BlueMonday merged commit e5fd4ec into BlueMonday:master Jan 31, 2024
@BlueMonday
Copy link
Owner

Made a few minor changes, hope you don't mind: e6cfda2

Also once again thank you for your contribution and helping keep the library up to date!

@BlueMonday
Copy link
Owner

Version v0.4.0 of this library should contain your changes.

@iammoonman
Copy link
Contributor Author

Thanks!

@iammoonman iammoonman deleted the api-updates branch January 31, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants