-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Types #28
New Types #28
Conversation
@@ -585,6 +617,8 @@ type CardFace struct { | |||
// This will only be set if the card is not in English. | |||
PrintedName *string `json:"printed_name"` | |||
|
|||
FlavorName *string `json:"flavor_name,omitempty"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was looking through the documented card face object and I don't see this one there. I only see it on the card object. Is the documentation incorrect? Do you happen to have an example card that has a card face with a flavor name?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmmm that one seems to not have multiple card faces so it only has the flavor_name on the card object and not on the card face object.
Thank you for helping keep the library up to date! Just have one question about one of the new fields! |
Made a few minor changes, hope you don't mind: e6cfda2 Also once again thank you for your contribution and helping keep the library up to date! |
Version v0.4.0 of this library should contain your changes. |
Thanks! |
Adds layouts and fields consistent with the Scryfall API as of Jan 2024.