Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix usage for Node 6 and Sails 0.12 #76

Merged
merged 4 commits into from
Jun 2, 2016
Merged

Conversation

joaosa
Copy link
Collaborator

@joaosa joaosa commented May 19, 2016

When using this with Node 6.1.0, I started getting:

sails-migrations "status"
.../node_modules undefined
path.js:7
    throw new TypeError('Path must be a string. Received ' + inspect(path));
    ^
TypeError: Path must be a string. Received undefined
    at assertPath (path.js:7:11)
    at Object.join (path.js:1211:7)
    at Function.SailsIntegration.getSailsConfig...

Updating liftoff did the trick.

While I was at it, I also noticed the configs for Sails 0.12 weren't being picked up properly. So I fixed that as well :)

Finally, there was a password authentication issue on node-postgres caused by Node 6. Taking knex/knex#1372 as a reference, I upgraded its version to 4.5.5, thus fixing the issue.

@joaosa joaosa mentioned this pull request May 30, 2016
@joaosa joaosa merged commit 373c725 into BlueHotDog:master Jun 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant