Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

neuron, coreneuron, nmodl: set modern units as default #2018

Merged
merged 1 commit into from
May 31, 2023

Conversation

iomaganaris
Copy link

No description provided.

@iomaganaris iomaganaris marked this pull request as draft May 31, 2023 08:12
@bbpbuildbot
Copy link
Collaborator

Thank you for your pull request!

Should you want to clear the PR build directory after failures, please use this pipeline. Before running the cleanup pipeline, please ensure that any PR building pipelines have been cancelled or finished running.

olupton
olupton previously approved these changes May 31, 2023
Copy link

@olupton olupton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link

There are one or more issues with the commit message of commit a797a8e.
Commit message:

Enable modern units by default in neuron, coreneuron and nmodl

Please satisfy at least one of the checks (one package, docs, or deploy).
The PR title must be compliant. The commit message of your commit must be compliant as well.
Issues:

  • The following packages were changed but not mentioned:
    coreneuron, nmodl, neuron:
    You can simply use the above list, then explain what you changed.
    Alternatively, you can use one line per package to describe the change per package.
    Please mention at least one package.

@bbpbuildbot
Copy link
Collaborator

To test your PR, use the following on BlueBrain5:

unset MODULEPATH
. /gpfs/bbp.cscs.ch/ssd/apps/bsd/pulls/2018/config/modules.sh
module load unstable

Please test the following updated modules:

  • brainbuilder/0.18.5
  • connectome-tools/0.6.2
  • neurodamus-hippocampus/1.8-2.15.0-2.7.0
  • neurodamus-mousify/1.6-2.15.0-2.7.0
  • neurodamus-neocortex-multiscale/1.11-2.15.0-2.7.0
  • neurodamus-neocortex-plasticity/1.11-2.15.0-2.7.0
  • neurodamus-neocortex/1.11-2.15.0-2.7.0
  • neurodamus-thalamus/1.6-2.15.0-2.7.0
  • neuron/9.0.a8
  • placement-algorithm/2.3.0
  • psp-validation/0.5.0
  • py-archngv/3.0.0
  • py-bbp-analysis-framework/1.6.42
  • py-bbp-workflow/3.1.19
  • py-bglibpy/4.10.1
  • py-bluepy/2.5.1
  • py-bluepyemodel/0.0.11
  • py-bluepymm/0.7.65
  • py-bluepyopt/1.13.86
  • py-bluepysnap/1.0.5
  • py-connectome-manipulator/0.0.4
  • py-currentscape/0.0.10
  • py-minis-validation/0.0.5
  • py-morph-tool/2.9.0
  • py-morphology-repair-workflow/2.0.3
  • py-region-grower/0.4.3
  • py-sonata-network-reduction/0.1.8

1 similar comment
@bbpbuildbot
Copy link
Collaborator

To test your PR, use the following on BlueBrain5:

unset MODULEPATH
. /gpfs/bbp.cscs.ch/ssd/apps/bsd/pulls/2018/config/modules.sh
module load unstable

Please test the following updated modules:

  • brainbuilder/0.18.5
  • connectome-tools/0.6.2
  • neurodamus-hippocampus/1.8-2.15.0-2.7.0
  • neurodamus-mousify/1.6-2.15.0-2.7.0
  • neurodamus-neocortex-multiscale/1.11-2.15.0-2.7.0
  • neurodamus-neocortex-plasticity/1.11-2.15.0-2.7.0
  • neurodamus-neocortex/1.11-2.15.0-2.7.0
  • neurodamus-thalamus/1.6-2.15.0-2.7.0
  • neuron/9.0.a8
  • placement-algorithm/2.3.0
  • psp-validation/0.5.0
  • py-archngv/3.0.0
  • py-bbp-analysis-framework/1.6.42
  • py-bbp-workflow/3.1.19
  • py-bglibpy/4.10.1
  • py-bluepy/2.5.1
  • py-bluepyemodel/0.0.11
  • py-bluepymm/0.7.65
  • py-bluepyopt/1.13.86
  • py-bluepysnap/1.0.5
  • py-connectome-manipulator/0.0.4
  • py-currentscape/0.0.10
  • py-minis-validation/0.0.5
  • py-morph-tool/2.9.0
  • py-morphology-repair-workflow/2.0.3
  • py-region-grower/0.4.3
  • py-sonata-network-reduction/0.1.8

@iomaganaris iomaganaris reopened this May 31, 2023
@iomaganaris iomaganaris marked this pull request as ready for review May 31, 2023 13:58
@iomaganaris iomaganaris enabled auto-merge (squash) May 31, 2023 14:01
@bbpbuildbot
Copy link
Collaborator

To test your PR, use the following on BlueBrain5:

unset MODULEPATH
. /gpfs/bbp.cscs.ch/ssd/apps/bsd/pulls/2018/config/modules.sh
module load unstable

Please test the following updated modules:

  • brainbuilder/0.18.5
  • connectome-tools/0.6.2
  • neurodamus-hippocampus/1.8-2.15.0-2.7.0
  • neurodamus-mousify/1.6-2.15.0-2.7.0
  • neurodamus-neocortex-multiscale/1.11-2.15.0-2.7.0
  • neurodamus-neocortex-plasticity/1.11-2.15.0-2.7.0
  • neurodamus-neocortex/1.11-2.15.0-2.7.0
  • neurodamus-thalamus/1.6-2.15.0-2.7.0
  • neuron/9.0.a8
  • placement-algorithm/2.3.0
  • psp-validation/0.5.0
  • py-archngv/3.0.0
  • py-bbp-analysis-framework/1.6.42
  • py-bbp-workflow/3.1.19
  • py-bglibpy/4.10.1
  • py-bluepy/2.5.1
  • py-bluepyemodel/0.0.11
  • py-bluepymm/0.7.65
  • py-bluepyopt/1.13.86
  • py-bluepysnap/1.0.5
  • py-connectome-manipulator/0.0.4
  • py-currentscape/0.0.10
  • py-minis-validation/0.0.5
  • py-morph-tool/2.9.0
  • py-morphology-repair-workflow/2.0.3
  • py-region-grower/0.4.3
  • py-sonata-network-reduction/0.1.8

@iomaganaris iomaganaris merged commit 8de4ef5 into develop May 31, 2023
@iomaganaris iomaganaris deleted the modern_units branch May 31, 2023 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants