Remove virtual from set_parent_for_children (issue #295) #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
set_parent_for_children is called only in the constructors. The virtual keyword unnecessary and generates only confusion.
tristan0x
approved these changes
Apr 14, 2020
pramodk
approved these changes
Apr 14, 2020
|
@cattabiani : can you rename on master and resolve conflict? |
set_parent_for_children is called only in the constructors. The virtual keyword unnecessary and generates only confusion.
|
I was bit concerned by "non-private non-virtual function being called through base class pointer pointing to derived class". But @tristan0x made that private and this is good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
set_parent_for_children is called only in the constructors. The
virtual keyword unnecessary and generates only confusion.
Check issue #295 for more info