Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix file copying for Python helper files. #1057

Merged
merged 3 commits into from
Sep 4, 2023
Merged

Conversation

1uc
Copy link
Collaborator

@1uc 1uc commented Aug 31, 2023

No description provided.

@bbpbuildbot

This comment has been minimized.

@1uc 1uc force-pushed the 1uc/fix-more-file-copying branch from a85adc3 to 5e28610 Compare August 31, 2023 15:38
@bbpbuildbot

This comment has been minimized.

@1uc 1uc force-pushed the 1uc/fix-more-file-copying branch from 5e28610 to 04ece95 Compare August 31, 2023 16:52
@bbpbuildbot

This comment has been minimized.

@codecov
Copy link

codecov bot commented Sep 1, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (8079c5e) 69.98% compared to head (7d710b9) 69.98%.
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1057   +/-   ##
=======================================
  Coverage   69.98%   69.98%           
=======================================
  Files         188      188           
  Lines       25659    25659           
=======================================
  Hits        17957    17957           
  Misses       7702     7702           

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bbpbuildbot

This comment has been minimized.

@1uc 1uc marked this pull request as ready for review September 1, 2023 07:30
@1uc 1uc marked this pull request as draft September 1, 2023 07:34
@1uc 1uc marked this pull request as ready for review September 1, 2023 08:29
Copy link
Contributor

@pramodk pramodk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just left one question for @tristan0x. Otherwise LGTM.

src/pybind/CMakeLists.txt Show resolved Hide resolved
@bbpbuildbot
Copy link
Collaborator

Logfiles from GitLab pipeline #149066 (:white_check_mark:) have been uploaded here!

Status and direct links:

@pramodk pramodk merged commit c4ab15e into master Sep 4, 2023
16 checks passed
@pramodk pramodk deleted the 1uc/fix-more-file-copying branch September 4, 2023 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants