Generate files as read-write. #1056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit generated files were created read-only. When updating files, one would add write permissions and then overwrite the file. Even if it was read-only. This commit changes the behaviour to generate files with regular (read & write) permissions and doesn't change the permissions of files, e.g. it wont overwrite read-only files.
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #1056 +/- ##
=======================================
Coverage 69.98% 69.98%
=======================================
Files 188 188
Lines 25659 25659
=======================================
Hits 17957 17957
Misses 7702 7702 ☔ View full report in Codecov by Sentry. |
|
Logfiles from GitLab pipeline #148649 (:white_check_mark:) have been uploaded here! Status and direct links: |
|
To check that the files are/should only generated in a build folder: |
pramodk
approved these changes
Sep 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit generated files were created read-only. When updating files, one would add write permissions and then overwrite the file. Even if it was read-only. This commit changes the behaviour to generate files with regular (read & write) permissions and doesn't change the permissions of files, e.g. it wont overwrite read-only files.