Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update forge.yml to use local file-to-resource-mapping.json #4821

Merged
merged 1 commit into from
Apr 3, 2024

Conversation

MFSY
Copy link
Contributor

@MFSY MFSY commented Apr 3, 2024

No description provided.

@@ -20,7 +20,7 @@ Store:
project_property: "https://bluebrain.github.io/nexus/vocabulary/project"
max_connection: 5
versioned_id_template: "{x.id}?rev={x._store_metadata._rev}"
file_resource_mapping: https://raw.githubusercontent.com/BlueBrain/nexus-forge/master/examples/configurations/nexus-store/file-to-resource-mapping.hjson
file_resource_mapping: https://raw.githubusercontent.com/BlueBrain/nexus/8851236f5bc38e113f1f04af2ca0bb31dab1c576/docs/src/main/paradox/docs/getting-started/notebooks/file-to-resource-mapping.hjson
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just follow the idea of having a specific commit in ref. I will not revise that in this PR.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if someone were to edit it hoping to have the edits reflected in its usage, it wouldn't work though?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Notebooks have to be updated as well for now. That would be my next PR.

Copy link
Contributor

@ssssarah ssssarah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a fan of the commit hash but I guess if this is urgent :)

@MFSY MFSY merged commit d9f6cb8 into master Apr 3, 2024
1 check passed
@MFSY MFSY deleted the use_local_file-to-resource-mapping branch April 3, 2024 09:58
imsdu pushed a commit to imsdu/nexus that referenced this pull request Apr 9, 2024
imsdu added a commit that referenced this pull request Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants