Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ngv test to use V10 emodels #183

Merged
merged 1 commit into from
Jul 22, 2024
Merged

Update ngv test to use V10 emodels #183

merged 1 commit into from
Jul 22, 2024

Conversation

WeinaJi
Copy link
Collaborator

@WeinaJi WeinaJi commented Jul 22, 2024

Context

Following the update of ngv/metabolism MOD files (BlueBrain/neurodamus-models#14), the v10 emodels should be used in the ngv test. This PR updates the ngv test config file in the neurodamus unit tests.

Scope

Update tests/simulations/ngv/circuit_config.json, the same as blueconfigs/sonataconf-quick-multiscale.

Testing

The existing tests/scientific-ngv.

Review

  • PR description is complete
  • Coding style (imports, function length, New functions, classes or files) are good
  • Unit/Scientific test added
  • Updated Readme, in-code, developer documentation

@bbpbuildbot
Copy link

@WeinaJi WeinaJi marked this pull request as ready for review July 22, 2024 08:11
@WeinaJi WeinaJi requested a review from jorblancoa July 22, 2024 08:11
@WeinaJi WeinaJi merged commit e8ac797 into main Jul 22, 2024
9 checks passed
@WeinaJi WeinaJi deleted the weji/ngv_test branch July 22, 2024 08:52
WeinaJi added a commit that referenced this pull request Oct 14, 2024
## Context
Following the update of ngv/metabolism MOD files
(BlueBrain/neurodamus-models#14), the v10
emodels should be used in the ngv test. This PR updates the ngv test
config file in the neurodamus unit tests.

## Scope
Update `tests/simulations/ngv/circuit_config.json`, the same as
`blueconfigs/sonataconf-quick-multiscale`.

## Testing
The existing `tests/scientific-ngv`.

## Review
* [x] PR description is complete
* [x] Coding style (imports, function length, New functions, classes or
files) are good
* [ ] Unit/Scientific test added
* [ ] Updated Readme, in-code, developer documentation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants