Replay with NetCons in CoreNEURON as in NEURON #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
WeinaJi
force-pushed
the
weji/replay_coreneuron
branch
from
d28a59a
to
fe8cac6
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
WeinaJi
force-pushed
the
weji/replay_coreneuron
branch
from
a4f181f
to
82c4a78
Compare
WeinaJi
changed the title
This comment has been minimized.
This comment has been minimized.
WeinaJi
changed the title
pramodk
reviewed
May 30, 2024
pramodk
reviewed
May 30, 2024
ferdonline
previously approved these changes
Jun 5, 2024
jorblancoa
previously approved these changes
Jun 6, 2024
WeinaJi
force-pushed
the
weji/replay_coreneuron
branch
from
82c4a78
to
d7ddeea
Compare
This comment has been minimized.
This comment has been minimized.
NEURODAMUS_MODELS_BRANCH=weji/GluSynapse
…ride until the next deployment of neurodamus-neocortex NEURODAMUS_MODELS_BRANCH=weji/GluSynapse BLUECONFIGS_BRANCH=weji/ref_v9
WeinaJi
force-pushed
the
weji/replay_coreneuron
branch
from
d7ddeea
to
2556b99
Compare
BLUECONFIGS_BRANCH=weji/ref_v9
WeinaJi
force-pushed
the
weji/replay_coreneuron
branch
from
2556b99
to
f9180ba
Compare
This comment has been minimized.
This comment has been minimized.
|
Logfiles from GitLab pipeline #218697 (:no_entry:) have been uploaded here! Status and direct links: |
ferdonline
approved these changes
Jun 25, 2024
WeinaJi
added a commit
that referenced
this pull request
Oct 14, 2024
## Context Currently Neurodamus uses different spike replay processes for NEURON and CoreNEURON: - For NEURON, it creates NetCons between a Vectim and the post synaptic object - For CoreNeuron, it writes the spikes into a .dat file and passes it to CoreNEURON via "–pattern" CLI h For the feature of running CoreNEURON in memory, we need to unify the synapse replay for both simulators. This PR makes CoreNEURON to replay as NEURON, using NetCons and VecStim. NetCons should be transferable between Neuron and CoreNEURON. ## Scope - In `node.py`, remove `_coreneuron_replay_append` for writing out replay data file. Call the same replay function for CoreNEURON. - In `connection_manager.py`, no `attach_src` for coreneuron virtual source. `replay_mode` from ReplayMode.NONE -> ReplayMode.AS_REQUIRED for coreneuron - In `neuromodulation_manager.py`, similar changes ## Testing Current tests ## Review * [x] PR description is complete * [x] Coding style (imports, function length, New functions, classes or files) are good * [x] Unit/Scientific test added * [ ] Updated Readme, in-code, developer documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Currently Neurodamus uses different spike replay processes for NEURON and CoreNEURON:
For NEURON, it creates NetCons between a Vectim and the post synaptic object
For CoreNeuron, it writes the spikes into a .dat file and passes it to CoreNEURON via "–pattern" CLI h
For the feature of running CoreNEURON in memory, we need to unify the synapse replay for both simulators. This PR makes CoreNEURON to replay as NEURON, using NetCons and VecStim. NetCons should be transferable between Neuron and CoreNEURON.
Scope
node.py, remove_coreneuron_replay_appendfor writing out replay data file. Call the same replay function for CoreNEURON.connection_manager.py, noattach_srcfor coreneuron virtual source.replay_modefrom ReplayMode.NONE -> ReplayMode.AS_REQUIRED for coreneuronneuromodulation_manager.py, similar changesTesting
Current tests
Review