Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplify the loading of input files in the io module #minor #335

Merged
merged 4 commits into from
Dec 11, 2023
Merged

Conversation

anilbey
Copy link
Contributor

@anilbey anilbey commented Dec 5, 2023

The current implementation is too complicated. It is re-implementing the wheel.

The PR adds a short function to do the same + it simplifies the test codes via the pathlib module.

@anilbey anilbey changed the title simplify the loading of ascii file in the io module simplify the loading of input files in the io module Dec 5, 2023
Copy link
Collaborator

@ilkilic ilkilic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done! Looks good to me

@anilbey anilbey changed the title simplify the loading of input files in the io module simplify the loading of input files in the io module #minor Dec 11, 2023
@anilbey anilbey merged commit 1d898c8 into master Dec 11, 2023
6 checks passed
@anilbey anilbey deleted the io branch December 11, 2023 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants