-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Nexus example #164
Add Nexus example #164
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #164 +/- ##
==========================================
- Coverage 60.07% 53.42% -6.66%
==========================================
Files 109 122 +13
Lines 7838 9674 +1836
==========================================
+ Hits 4709 5168 +459
- Misses 3129 4506 +1377 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. I have some minor comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in run_emodel_search_thresh.ipynb:
-Looks like we have an error :
EModel.init() got an unexpected keyword argument 'nexus_images'
It looks like you might have to change EModel init()
-maybe the threshold search could use a few more comments
-your ramp current is a step
-you could modify the title of the notebook by 'Download an e-model as a hoc file and run it with BlueCelluLab'
examples/nexus/README.md
Outdated
@@ -0,0 +1,163 @@ | |||
# E-Model Building Pipeline with Luigi and Nexus |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So this is using bbp-workflow. Can it be used outside of bb5? If not, we should say it clearly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
afaik it cannot be used outisde bb5. I have updated the readme make it clearer and added a note that python 3.10 is required for this example, as bbp-workflow only supports python versions 3.10 and higher.
sorry, I accidentally committed this file. It shouldn't be here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for your effort!
No description provided.