Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Nexus example #164

Merged
merged 20 commits into from
Aug 13, 2024
Merged

Add Nexus example #164

merged 20 commits into from
Aug 13, 2024

Conversation

ilkilic
Copy link
Collaborator

@ilkilic ilkilic commented Jul 30, 2024

No description provided.

@ilkilic ilkilic self-assigned this Jul 30, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jul 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.42%. Comparing base (8d5b0ab) to head (38b15a7).
Report is 78 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #164      +/-   ##
==========================================
- Coverage   60.07%   53.42%   -6.66%     
==========================================
  Files         109      122      +13     
  Lines        7838     9674    +1836     
==========================================
+ Hits         4709     5168     +459     
- Misses       3129     4506    +1377     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@darshanmandge darshanmandge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I have some minor comments.

examples/README.md Outdated Show resolved Hide resolved
examples/README.md Outdated Show resolved Hide resolved
examples/others/memodel/memodel.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@AurelienJaquier AurelienJaquier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in run_emodel_search_thresh.ipynb:
-Looks like we have an error :
EModel.init() got an unexpected keyword argument 'nexus_images'
It looks like you might have to change EModel init()
-maybe the threshold search could use a few more comments
-your ramp current is a step
-you could modify the title of the notebook by 'Download an e-model as a hoc file and run it with BlueCelluLab'

examples/nexus/README.md Outdated Show resolved Hide resolved
@@ -0,0 +1,163 @@
# E-Model Building Pipeline with Luigi and Nexus
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this is using bbp-workflow. Can it be used outside of bb5? If not, we should say it clearly

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

afaik it cannot be used outisde bb5. I have updated the readme make it clearer and added a note that python 3.10 is required for this example, as bbp-workflow only supports python versions 3.10 and higher.

examples/nexus/README.md Outdated Show resolved Hide resolved
examples/nexus/README.md Outdated Show resolved Hide resolved
examples/nexus/README.md Outdated Show resolved Hide resolved
examples/nexus/exploit_model.ipynb Show resolved Hide resolved
examples/nexus/pipeline.py Outdated Show resolved Hide resolved
examples/nexus/run_pipeline.ipynb Outdated Show resolved Hide resolved
examples/nexus/run_pipeline.ipynb Outdated Show resolved Hide resolved
examples/nexus/pipeline.py Outdated Show resolved Hide resolved
@ilkilic
Copy link
Collaborator Author

ilkilic commented Aug 7, 2024

in run_emodel_search_thresh.ipynb: -Looks like we have an error : EModel.init() got an unexpected keyword argument 'nexus_images' It looks like you might have to change EModel init() -maybe the threshold search could use a few more comments -your ramp current is a step -you could modify the title of the notebook by 'Download an e-model as a hoc file and run it with BlueCelluLab'

sorry, I accidentally committed this file. It shouldn't be here. run_emodel.ipynb is the correct one.

examples/others/memodel/README.md Outdated Show resolved Hide resolved
examples/others/memodel/memodel.py Outdated Show resolved Hide resolved
examples/README.md Outdated Show resolved Hide resolved
examples/nexus/create_venv.sh Show resolved Hide resolved
Copy link
Collaborator

@darshanmandge darshanmandge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for your effort!

@ilkilic ilkilic merged commit f3c4dae into main Aug 13, 2024
6 checks passed
@ilkilic ilkilic deleted the nexus-example branch August 13, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants