allow user to use custom function for simulation callback #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #211 +/- ##
==========================================
- Coverage 91.24% 91.22% -0.02%
==========================================
Files 95 95
Lines 5708 5721 +13
==========================================
+ Hits 5208 5219 +11
- Misses 500 502 +2 ☔ View full report in Codecov by Sentry. |
Dinika
approved these changes
Sep 3, 2024
ilkilic
approved these changes
Sep 3, 2024
bilalesi
approved these changes
Sep 3, 2024
There was a problem hiding this comment.
@AurelienJaquier thanks for the PR, I left a comment regarding cvode
Comment on lines
78
to
79
| neuron.h.cvode.event( | ||
| neuron.h.t + self.progress_dt, self.progress_callback) |
There was a problem hiding this comment.
what if the cvode is disabled
for synaptome simulation, we have to disable the cvode, so i don't know if the event will be triggered hence the progress_callback will work ?
There was a problem hiding this comment.
I have tested with cvode disabled, and the callback function is still called.
bilalesi
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.