Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example 7 proposition #194

Merged
merged 6 commits into from
Aug 15, 2024
Merged

Example 7 proposition #194

merged 6 commits into from
Aug 15, 2024

Conversation

ejayromero
Copy link
Contributor

Proposition to add some examples of protocols, which are mainly based on some Bluecellulab's examples and functions.
The example contains:

  1. Negative and rheobase step current
  2. Multiple negative step current
  3. IV-curve resulting from previous example.
  4. Multiple positive step current
  5. FI-curve resulting from previous example
  6. Voltage sag vs distance from soma on multiple dendrites positions
  7. A modified EPSP which compared Psp ratio vs distance to soma on multiple dendrites positions

All examples have the detailed code and plot for analysis.

Copy link
Contributor

@AurelienJaquier AurelienJaquier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!
Could you add your example to the table in examples/README.rst?

examples/7-Extra-Simulation/Multiple-protocols.ipynb Outdated Show resolved Hide resolved
examples/7-Extra-Simulation/Multiple-protocols.ipynb Outdated Show resolved Hide resolved
examples/7-Extra-Simulation/Multiple-protocols.ipynb Outdated Show resolved Hide resolved
examples/7-Extra-Simulation/Multiple-protocols.ipynb Outdated Show resolved Hide resolved
examples/7-Extra-Simulation/Multiple-protocols.ipynb Outdated Show resolved Hide resolved
examples/7-Extra-Simulation/Multiple-protocols.ipynb Outdated Show resolved Hide resolved
examples/7-Extra-Simulation/Multiple-protocols.ipynb Outdated Show resolved Hide resolved
examples/7-Extra-Simulation/Multiple-protocols.ipynb Outdated Show resolved Hide resolved
examples/7-Extra-Simulation/Multiple-protocols.ipynb Outdated Show resolved Hide resolved
Copy link
Contributor

@AurelienJaquier AurelienJaquier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks @ejayromero

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.24%. Comparing base (47d1931) to head (a1f61d9).
Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #194      +/-   ##
==========================================
- Coverage   91.24%   91.24%   -0.01%     
==========================================
  Files          95       95              
  Lines        5691     5708      +17     
==========================================
+ Hits         5193     5208      +15     
- Misses        498      500       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@darshanmandge darshanmandge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution @ejayromero!

@AurelienJaquier AurelienJaquier merged commit 97aa879 into BlueBrain:main Aug 15, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants