Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix accessing afferent_section_pos of synapse description #169

Merged
merged 5 commits into from
Apr 30, 2024
Merged

Conversation

anilbey
Copy link
Contributor

@anilbey anilbey commented Apr 29, 2024

addresses "afferent_section_pos" / SynapseProperty.AFFERENT_SECTION_POS confusion across SONATA & bluepy implementations

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 17.64706% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 91.12%. Comparing base (187fce6) to head (90ebc5d).

Files Patch % Lines
bluecellulab/circuit/synapse_properties.py 0.00% 14 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #169      +/-   ##
==========================================
- Coverage   91.32%   91.12%   -0.20%     
==========================================
  Files          95       95              
  Lines        5577     5589      +12     
==========================================
  Hits         5093     5093              
- Misses        484      496      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@anilbey anilbey marked this pull request as ready for review April 30, 2024 09:46
Copy link

@joni-herttuainen joni-herttuainen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems to work as expected, now. LGTM

@anilbey anilbey merged commit 8db0f26 into main Apr 30, 2024
10 checks passed
@anilbey anilbey deleted the syn-props branch April 30, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants