Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TStim implementation in add_step and add_ramp #147

Merged
merged 3 commits into from
Mar 8, 2024
Merged

TStim implementation in add_step and add_ramp #147

merged 3 commits into from
Mar 8, 2024

Conversation

anilbey
Copy link
Contributor

@anilbey anilbey commented Mar 7, 2024

TStim implementation is using the event based stimulus representation that has performance benefits in NEURON simulator.

@anilbey anilbey changed the title use dt=1.0 by default in add_step and add_ramp TStim implementation in add_step and add_ramp Mar 8, 2024
@arnaudon
Copy link
Contributor

arnaudon commented Mar 8, 2024

thanks, its now as fast as before!

@anilbey anilbey marked this pull request as ready for review March 8, 2024 13:43
@anilbey anilbey merged commit eb63577 into main Mar 8, 2024
10 checks passed
@anilbey anilbey deleted the benchmark branch March 8, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants