-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable injecting Python generated Stimuli [vcs: #minor] #142
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #142 +/- ##
==========================================
+ Coverage 85.30% 89.23% +3.92%
==========================================
Files 80 87 +7
Lines 5404 5387 -17
==========================================
+ Hits 4610 4807 +197
+ Misses 794 580 -214 ☔ View full report in Codecov by Sentry. |
eaa09d6
to
5c735bc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @anilbey! It's nice that you have added tests and example notebook for the new stimuli. It looks good to me. It is good to merge if it is fine for the GUI @stefanoantonel
Looks good to me! |
Adds a layer to create stimuli in Python and combine them with
+
operator. It does not use NEURON and it is not dependent on the Cell module. The current trace of each generated stimuli can be retrieved consistently.Changes