Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: pass CODECOV token in release->test workflow call #141

Merged
merged 1 commit into from
Feb 26, 2024
Merged

CI: pass CODECOV token in release->test workflow call #141

merged 1 commit into from
Feb 26, 2024

Conversation

anilbey
Copy link
Contributor

@anilbey anilbey commented Feb 26, 2024

Issue

The coverage was only getting updated for the PR branches not main.

Reason

For security reasons when we call a workflow from the other we need to specify the env vars.

To upload the coverage of the main we do 2 workflow calls.

  1. release.yml -> test.yml
  2. test.yml -> codecov's workflow

Solution

Previously in 2, the secret is passed. In 1 it was not. Now both of them pass.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.96%. Comparing base (d7a5240) to head (e898ec3).
Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #141      +/-   ##
==========================================
+ Coverage   85.30%   88.96%   +3.65%     
==========================================
  Files          80       84       +4     
  Lines        5404     5183     -221     
==========================================
+ Hits         4610     4611       +1     
+ Misses        794      572     -222     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@anilbey anilbey changed the title pass CODECOV token in release->test workflow call CI: pass CODECOV token in release->test workflow call Feb 26, 2024
@anilbey anilbey merged commit edfb266 into main Feb 26, 2024
10 checks passed
@anilbey anilbey deleted the ci branch February 26, 2024 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants