Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow API functions to be used without loading hoc/mod #minor #124

Merged
merged 2 commits into from
Feb 2, 2024
Merged

Conversation

anilbey
Copy link
Contributor

@anilbey anilbey commented Feb 1, 2024

Previously loading the hoc and mod files were taking place during import bluecellulab.

This was coupling every function in the API with the hoc and mods. With this change only the creation of SSim, Cell and RNGSettings objects is triggering the loading of mod and hoc files (once and only once).

Minis-validation tests pass:

  py310: OK (125.48=setup[66.64]+cmd[11.43,47.41] seconds)
  congratulations :) (125.69 seconds)

PSP-validation tests pass:

74 passed, 87 warnings in 334.98s (0:05:34) 
  py310: OK (408.65=setup[68.46]+cmd[4.54,335.65] seconds)
  congratulations :) (408.86 seconds)


@anilbey anilbey requested a review from ilkilic February 1, 2024 16:59
@anilbey anilbey changed the title load hoc and mod when required to allow API functions to be used without them #minor load hoc and mod when required. Allow API functions to be used without them #minor Feb 1, 2024
@anilbey anilbey changed the title load hoc and mod when required. Allow API functions to be used without them #minor Allow API functions to be used without loading hoc/mod #minor Feb 1, 2024
Copy link
Contributor

@ilkilic ilkilic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks perfect!

@anilbey anilbey merged commit d7a5240 into main Feb 2, 2024
10 checks passed
@anilbey anilbey deleted the imports branch February 2, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants