libsonata has in the process of refactoring its module #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mgeplf
commented
Feb 1, 2024
mgeplf
commented
- make this forwards and backwards compatible
- see Make documentation available for Python API libsonata#345
* make this forwards and backwards compatible
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #123 +/- ##
==========================================
- Coverage 85.14% 85.11% -0.03%
==========================================
Files 78 78
Lines 5344 5356 +12
==========================================
+ Hits 4550 4559 +9
- Misses 794 797 +3 ☔ View full report in Codecov by Sentry. |
mgeplf
added a commit
to BlueBrain/libsonata
that referenced
this pull request
Feb 5, 2024
* CircuitConfig, NodeSets, and SimulationConfig didn't have a top level
docstring and thus sphinx `automodule` wasn't displaying them
* Many of the SimulationConfig were rooted in _libsonata, when they
should be in SimulationConfig; this was refactored, however it has
implications in the following projects:
* BlueCelluLab was update to work around the change
BlueBrain/BlueCelluLab#123
* SNAP tests have been updated to handle the different locations of
SimulationConfig classes:
BlueBrain/snap#254
mgeplf
added a commit
to BlueBrain/libsonata
that referenced
this pull request
Feb 7, 2024
* CircuitConfig, NodeSets, and SimulationConfig didn't have a top level
docstring and thus sphinx `automodule` wasn't displaying them
* Many of the SimulationConfig were rooted in _libsonata, when they
should be in SimulationConfig; this was refactored, however it has
implications in the following projects:
* BlueCelluLab was update to work around the change
BlueBrain/BlueCelluLab#123
* SNAP tests have been updated to handle the different locations of
SimulationConfig classes:
BlueBrain/snap#254
mgeplf
added a commit
to BlueBrain/libsonata
that referenced
this pull request
Feb 23, 2024
* CircuitConfig, NodeSets, and SimulationConfig didn't have a top level
docstring and thus sphinx `automodule` wasn't displaying them
* Many of the SimulationConfig were rooted in _libsonata, when they
should be in SimulationConfig; this was refactored, however it has
implications in the following projects:
* BlueCelluLab was update to work around the change
BlueBrain/BlueCelluLab#123
* SNAP tests have been updated to handle the different locations of
SimulationConfig classes:
BlueBrain/snap#254
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.