Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

access public hoc templates with getCell or CellRef #106

Merged
merged 1 commit into from
Nov 1, 2023
Merged

Conversation

anilbey
Copy link
Contributor

@anilbey anilbey commented Oct 31, 2023

No description provided.

@codecov-commenter
Copy link

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (e7f1f3f) 84.08% compared to head (ca9f277) 84.83%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #106      +/-   ##
==========================================
+ Coverage   84.08%   84.83%   +0.74%     
==========================================
  Files          76       76              
  Lines        5197     5275      +78     
==========================================
+ Hits         4370     4475     +105     
+ Misses        827      800      -27     
Files Coverage Δ
bluecellulab/cell/template.py 95.06% <100.00%> (+0.39%) ⬆️
bluecellulab/ssim.py 85.76% <100.00%> (+0.05%) ⬆️
tests/test_cell/test_core.py 99.13% <100.00%> (+0.26%) ⬆️
tests/test_cell/test_template.py 100.00% <100.00%> (ø)
bluecellulab/cell/core.py 75.66% <96.36%> (+6.27%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@anilbey anilbey requested a review from darshanmandge October 31, 2023 17:49
@anilbey
Copy link
Contributor Author

anilbey commented Oct 31, 2023

@darshanmandge could you check if this works fine in your template (without adding getCell()) to it?

Copy link
Contributor

@darshanmandge darshanmandge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @anilbey. It now works for the hoc template without adding the getCell() function!

@anilbey anilbey merged commit a86cd4e into main Nov 1, 2023
9 checks passed
@anilbey anilbey deleted the templates branch November 1, 2023 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants