Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add file_offset functionality #409

Merged
merged 9 commits into from
Jul 5, 2022
Merged

Add file_offset functionality #409

merged 9 commits into from
Jul 5, 2022

Conversation

oscargm98
Copy link
Contributor

@oscargm98 oscargm98 commented Jul 1, 2022

  • New parameter file_offset of the blosc2_frame_s struct
  • New blosc2_schunk_open_offset() function
  • New blosc2_schunk_append_file() function
  • New test_frame_offset.c test

Copy link
Member

@FrancescAlted FrancescAlted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a comment. But other than this, everything looks good!

blosc/frame.c Show resolved Hide resolved
Copy link
Member

@FrancescAlted FrancescAlted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FrancescAlted FrancescAlted merged commit 0226e7b into main Jul 5, 2022
@FrancescAlted FrancescAlted deleted the schunk_open_offset branch July 5, 2022 08:56
@FrancescAlted FrancescAlted restored the schunk_open_offset branch July 5, 2022 08:56
@FrancescAlted FrancescAlted deleted the schunk_open_offset branch July 5, 2022 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants