Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DockerBuildPush.yml #29

Merged
merged 1 commit into from
Oct 9, 2020
Merged

Conversation

Jwilson1172
Copy link
Contributor

@Jwilson1172 Jwilson1172 commented Oct 9, 2020

Description

I'm not 100% sure why the docker buildx didn't work I used the same
PATH context and --file FILE specifications that I use locally

the Build command is:

/usr/bin/docker buildx build \
--tag SECRET \
--iidfile /tmp/docker-build-push-4PJV9W/iidfile \ 
--cache-from type=local,src=/tmp/.buildx-cache \ 
--cache-to type=local,dest=/tmp/.buildx-cache \
--file ./project/Dockerfile \
--push \
./project

the output from the build command is:

unable to prepare context: path "./project" not found

In this PR I try removing the relative path specifier to see if that's the problem.
so the new command is going to be:

/usr/bin/docker buildx build \
--tag SECRET \
--iidfile /tmp/docker-build-push-4PJV9W/iidfile \ 
--cache-from type=local,src=/tmp/.buildx-cache \ 
--cache-to type=local,dest=/tmp/.buildx-cache \
--file project/Dockerfile \
--push \
project

On the next iteration I will rebuild the workflow from scratch if this doesn't work using standard docker build command.
dropping the caching service and builder pool options that come with docker buildx in favor of something that works as expected.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Change Status

  • Complete, tested, ready to review and merge
  • Complete, but not tested (may need new tests)
  • Incomplete/work-in-progress, PR is for discussion/feedback

Has This Been Tested

  • Yes
  • No
  • Not necessary

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • There are no merge conflicts

@Jwilson1172
Copy link
Contributor Author

Jwilson1172 commented Oct 9, 2020

as per docker/setup-buildx-action#29
and https://github.com/docker/setup-buildx-action/tags
the v1 tag uses the v1.0.2 image which may have some problems that have yet to be fully documented.
I may also want to specify the tag as v1.0.1 which was the previous latest stable release of the buildx image.

Copy link
Contributor

@lorischl-otter lorischl-otter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hope this does the trick!

@lorischl-otter lorischl-otter merged commit dc6a005 into main Oct 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants