Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/complexity score mvp #18

Merged
merged 6 commits into from
Oct 6, 2020
Merged

Conversation

lorischl-otter
Copy link
Contributor

@lorischl-otter lorischl-otter commented Oct 6, 2020

Description

squad_score.py includes two functions that take a transcription string, and output both a single row dataframe of metrics and then a single integer for Squad Score. This initial formula only includes the native Python features (4), and the next iteration will include an additional feature using nltk. squad_score.py is not currently written with integration with any other files, but these functions can be exported for use elsewhere. This current formula has a correlation of -.60 with our 25 rankings.

Updated utils README to reflect file additions, and requirements.txt to reflect new imports in squad_score.py.

I'll be doing a second pull request on a different branch to get the completed notebook up.

Note: initial commit included auto commits that removed the Docker file and preemptively updated the squad_score_mvp_notebook, which is why that commit was reverted.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Change Status

  • Complete, tested, ready to review and merge
  • Complete, but not tested (may need new tests)
  • Incomplete/work-in-progress, PR is for discussion/feedback

Has This Been Tested

  • Yes
  • No
  • Not necessary

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • There are no merge conflicts

@Jwilson1172 Jwilson1172 self-requested a review October 6, 2020 16:43
Copy link
Contributor

@Jwilson1172 Jwilson1172 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good thank you for getting those changes implemented for me.

Copy link
Contributor

@schase15 schase15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Very readable code

@schase15 schase15 merged commit 26759b7 into main Oct 6, 2020
@Jwilson1172 Jwilson1172 mentioned this pull request Oct 6, 2020
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants