-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/complexity score mvp #18
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 86ad0a5.
…revious dirty commit
Jwilson1172
reviewed
Oct 6, 2020
Jwilson1172
suggested changes
Oct 6, 2020
Jwilson1172
approved these changes
Oct 6, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good thank you for getting those changes implemented for me.
schase15
approved these changes
Oct 6, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Very readable code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
squad_score.py
includes two functions that take a transcription string, and output both a single row dataframe of metrics and then a single integer for Squad Score. This initial formula only includes the native Python features (4), and the next iteration will include an additional feature usingnltk
.squad_score.py
is not currently written with integration with any other files, but these functions can be exported for use elsewhere. This current formula has a correlation of -.60 with our 25 rankings.Updated
utils
README to reflect file additions, and requirements.txt to reflect new imports in squad_score.py.I'll be doing a second pull request on a different branch to get the completed notebook up.
Note: initial commit included auto commits that removed the Docker file and preemptively updated the
squad_score_mvp_notebook
, which is why that commit was reverted.Type of change
Change Status
Has This Been Tested
Checklist