Feature/google api #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lorischl-otter
suggested changes
Sep 17, 2020
There was a problem hiding this comment.
Looks great overall! Just added in a few suggestions for changes & documentation updates. Also, I'm unclear on the Change Status vs Has This Been Tested boxes that are checked in the PR template. Could you change that so it's not a conflicting message of "Complete, but not tested" and "Yes" it has been tested? Thanks!
|
I also fixed the PR Description, I always assumed that one of the tested prompts was specific to unit-testing and one was specific to testing the functionality locally. |
schase15
approved these changes
Sep 18, 2020
lorischl-otter
approved these changes
Sep 18, 2020
lorischl-otter
approved these changes
Sep 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds an OOP GoogleAPI service to the application. It also configures the endpoints in submission.py to provide text transcriptions and safe search moderation functionality.
Type of change
Change Status
Has This Been Tested
Checklist
1 - The class that is implemented in
project/app/utils/google_api.pywill throw an error and stop execution if no Google Credentials are provided in the environment variable GOOGLE_CREDS. the contents of this variable are the JSON in the service_account.json credential file that is downloaded from the Google Cloud Dashboard.