generated from BloomTech-Labs/labs-spa-starter
-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bl 935 fe i want to approve instructor course proposals #341
Draft
jzkime
wants to merge
12
commits into
main
Choose a base branch
from
BL-935-fe-i-want-to-approve-instructor-course-proposals
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Bl 935 fe i want to approve instructor course proposals #341
jzkime
wants to merge
12
commits into
main
from
BL-935-fe-i-want-to-approve-instructor-course-proposals
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to keep in mind that with this branch we've not removed the routes and components that originally made up the courses system from before, although those need to be heavily reworked and altered. |
JackNunnink
reviewed
Nov 18, 2022
|
||
#modal-header { | ||
height: 2rem; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add an end-of-line break \n
here. Just for syntax purposes
JackNunnink
approved these changes
Nov 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this branch we included a course proposal acceptance system inside a modal on the admin programs page as requested from stakeholder.
Jira Ticket
Loom Video
Please paste a link here of a quick loom video walking through what you did in your PR.
Type of change
Author and Co-Authors
Esmodea Burk
Jazmine Kime
Gage Clancy