Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: app scoped role assignment not properly linking to AZApp #78

Merged
merged 1 commit into from
Apr 26, 2024

Conversation

mistahj67
Copy link
Contributor

BED-4348

Adds workaround handling for app specific scoped role assignments. This ensures that downstream ingestion by Bloodhound will add edge to correct AZApp node

Implementation

Expanded directoryScope in ListAzureADRoleAssignments which provides the appId of the scoped app.
Hotswapped that in place for the directoryScopeId to be consumed downstream.

No changes needed to Bloodhound.

Testing

Ran collection locally pointing at Azure env with role assignment scoped to specific app and ensured that it was properly linked in Bloodhound.

Query: MATCH p = (:AZUser)-[:AZAppAdmin]->()

@mistahj67 mistahj67 changed the title fix: app scoped role assgnmt not properly linking to AZApp fix: app scoped role assignment not properly linking to AZApp Apr 26, 2024
@mistahj67 mistahj67 merged commit 9f36bca into main Apr 26, 2024
9 checks passed
@mistahj67 mistahj67 deleted the BED-4348 branch April 26, 2024 17:00
@github-actions github-actions bot locked and limited conversation to collaborators Apr 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants