Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump bitcoin and elements dep #137

Merged
merged 3 commits into from
Jan 17, 2025
Merged

Bump bitcoin and elements dep #137

merged 3 commits into from
Jan 17, 2025

Conversation

RCasatta
Copy link
Collaborator

When building without liquid feature there are warnings to use compute_txid but by fixing those the build with the liquid feature fails because there the methods is still just txid

@shesek
Copy link
Collaborator

shesek commented Jan 14, 2025

there are warnings to use compute_txid but by fixing those the build with the liquid feature fails because there the methods is still just txid

I ran into a similar situation with deprecated methods when updating to rust-bitcoin v0.31 and ended up resolving them with some ebcompact traits that adds compatible methods to the rust-elements structs. A compute_txid->txid alias would fit there nicely.

shesek
shesek reviewed Jan 14, 2025
View reviewed changes
src/util/script.rs Outdated Show resolved Hide resolved
@RCasatta
Copy link
Collaborator Author

I ran into a similar situation with deprecated methods when updating to rust-bitcoin v0.31 and ended up resolving them with some ebcompact traits that adds compatible methods to the rust-elements structs. A compute_txid->txid alias would fit there nicely.

Done in 67b465b

@RCasatta RCasatta marked this pull request as ready for review January 14, 2025 09:07
@RCasatta RCasatta mentioned this pull request Jan 14, 2025
Closed
shesek
shesek approved these changes Jan 16, 2025
View reviewed changes
Copy link
Collaborator

@shesek shesek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 56e03c8

@RCasatta RCasatta merged commit 21930be into new-index Jan 17, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philippem philippem philippem left review comments

@shesek shesek shesek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RCasatta @shesek @philippem