Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fix help center page #56

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

No-bodyq
Copy link

@No-bodyq No-bodyq commented Dec 13, 2024

Description

Detailed description of proposed changes

Related Issue(s)

Closes #48

Checklist:

  • Read the contributing docs (if this is your first contribution)

  • Verified this is not a duplicate of any existing pull request

  • Performed a self-review of the code

  • Rebased to the last commit of the target branch (or merged it into my branch)

  • Linked the issues which this PR resolves

  • Documented the changes in code (API docs will be generated automatically)

@No-bodyq
Copy link
Author

Please review @Abeeujah, @Oshioke-Salaki

@Oshioke-Salaki
Copy link
Collaborator

Screenshot 2024-12-16 at 18 04 23 There is a lot of space between the left and right hand sides of this page.

Also the attachments input does not match the one on the figma

Also when a file is attached, it is supposed to show that a file has been inputted.

@No-bodyq
Copy link
Author

Okay thank you, I will fix that

Copy link
Collaborator

@princeibs princeibs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you ensure the file input field implementation aligns with the UI design?

@No-bodyq
Copy link
Author

Yes, I'll do that

@No-bodyq No-bodyq requested a review from princeibs December 16, 2024 19:59
@No-bodyq
Copy link
Author

Made requested changes @Oshioke-Salaki, @princeibs

@Oshioke-Salaki
Copy link
Collaborator

Build fails

@No-bodyq
Copy link
Author

Hello @Oshioke-Salaki, I don't think that is on my end:
The error is in select-base-token.tsx according to the workflow which i did not touch.
Please confirm

@Oshioke-Salaki
Copy link
Collaborator

Implement drag and drop functionality in the attachments

@No-bodyq
Copy link
Author

Done @Oshioke-Salaki

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Help Center Page
3 participants