Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Question sets are not getting scored correctly #8

Closed
andrewjkerr opened this issue Jul 13, 2015 · 7 comments
Closed

Question sets are not getting scored correctly #8

andrewjkerr opened this issue Jul 13, 2015 · 7 comments
Assignees
@andrewjkerr

Comments

@andrewjkerr
Copy link
Contributor

The PHP lib currently does not send a proper request to the BlockScore API resulting in incorrectly scored questions.

http://docs.blockscore.com/v4.0/curl/#score-a-question-set
@andrewjkerr andrewjkerr self-assigned this Jul 13, 2015
andrewjkerr added a commit that referenced this issue Jul 13, 2015
@andrewjkerr
Fixes #8
ff9de0f
@tjchambers
Copy link
Contributor

If this is fixed why is it still open?

@alainmeier alainmeier reopened this Jan 29, 2016
@alainmeier
Copy link
Member

#9 not closed yet

@backus
Copy link
Member

backus commented Jan 29, 2016

@tjchambers could you review #9 possibly and then merge it if it seems good to you? I think one of us reviewed it back in the day but I just don't know much about PHP compared to you

@tjchambers
Copy link
Contributor

@alainmeier The fix for this may work, but this is one of those very poorly implemented query parm concatenation code. It should be rewritten. I will rewrite it.

@alainmeier
Copy link
Member

Thank you @tjchambers

@tjchambers
Copy link
Contributor

@alainmeier Do you want the version bumped to 4.0.2 when I implement this on another PR?

@alainmeier
Copy link
Member

@tjchambers yes please, I would like to get this pushed to package managers when it's done

tjchambers added a commit that referenced this issue Mar 24, 2016
@tjchambers
Correct question set results scoring per #8
86ce6a9 
Previously the response was not sending the question_id and answer_id to the backend API, resulting in no valid response.
alainmeier added a commit that referenced this issue Mar 24, 2016
@alainmeier
Merge pull request #13 from BlockScore/fix/query_parm_qs
5ecb8e3 
Correct question set results scoring per #8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andrewjkerr andrewjkerr

Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@tjchambers @alainmeier @andrewjkerr @backus