-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: revamp reorg handling logic #63
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…) + allow to set the network to be indexed
…ced slots do not exist
PJColombo
changed the title
fix: update reorg handling logic
fix: revamp reorg handling logic
Mar 10, 2024
PJColombo
force-pushed
the
fix/reorg-blocks-handling
branch
from
March 10, 2024 02:56
edb7a09
to
b591dd9
Compare
0xGabi
approved these changes
Mar 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done!
I left a couple of reviews.
Co-authored-by: Gabi <[email protected]>
…e `Network` struct
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It requires the api changes from the following PR: #272.
This PR changes the way the indexer is handling reorgs. It specifically removes the problematic reorg handling logic within the
synchronizer
andslots-processor
components and it introduces an update that enables the indexer to now listen forchain_reorg
SSE (Server-Sent Events) and then identifying the slots associated with the forked blocks and subsequently invoking the updated blobscan's reorg handling endpoint.