Merge pull request #1 from Blistic/issue1568

Fix deallocation of incorrect pointer (pybind#1568)
Blistic · Nov 4, 2018 · 691f455 · 691f455
2 parents 978d439 + aa4113b
commit 691f455
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/include/pybind11/detail/class.h b/include/pybind11/detail/class.h
@@ -222,7 +222,7 @@ inline bool deregister_instance_impl(void *ptr, instance *self) {
     auto &registered_instances = get_internals().registered_instances;
     auto range = registered_instances.equal_range(ptr);
     for (auto it = range.first; it != range.second; ++it) {
-        if (Py_TYPE(self) == Py_TYPE(it->second)) {
+        if (self == it->second) {
             registered_instances.erase(it);
             return true;
         }