Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#190 - Test and fix for fetch joins with scalar selects #389

Merged
merged 1 commit into from
Mar 18, 2017

Conversation

beikov
Copy link
Member

@beikov beikov commented Mar 15, 2017

This is required for being able to implement #257 so hurry with reviewing ;)

@beikov beikov requested a review from Mobe91 March 15, 2017 14:39
Copy link
Contributor

@Mobe91 Mobe91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, it would be nice to avoid an additional api method fetchOnly. Instead, fetch paths specified by fetch should be implicitely pruned in presence of a scalar select.

@beikov beikov force-pushed the issues/190 branch 2 times, most recently from 41c71c9 to 02a3198 Compare March 17, 2017 12:23
…fetch base for relations that should be fetched. Fixed date extract test.
Copy link
Contributor

@Mobe91 Mobe91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move all the date/time/timezone related stuff to a separate commit.

@@ -72,7 +72,7 @@ public BaseSubqueryBuilderImpl(MainQuery mainQuery, AliasManager aliasManager, J
public T getResult() {
return result;
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please revert

@Mobe91 Mobe91 merged commit dbea7da into Blazebit:master Mar 18, 2017
@beikov beikov deleted the issues/190 branch March 21, 2017 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants