Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fromValues() not working in CTE definition #304

Closed
Mobe91 opened this issue Nov 24, 2016 · 1 comment
Closed

fromValues() not working in CTE definition #304

Mobe91 opened this issue Nov 24, 2016 · 1 comment
Assignees
@Mobe91
Labels
kind: bug
Milestone
1.2.0

Comments

@Mobe91
Copy link
Contributor

Mobe91 commented Nov 24, 2016

When fromValues() is used to define a CTE, the resulting SQL is invalid and does not contain the values parameters.
@Mobe91
Copy link
Contributor Author

Mobe91 commented Nov 24, 2016

@beikov suggested that it might be sufficient to change

if (hasLimit())

in com.blazebit.persistence.impl.AbstractCTECriteriaBuilder:79 to

if (hasLimit() || joinManager.hasEntityFunctions() || !keyRestrictedLeftJoins.isEmpty())

This need thorough testing!

@beikov beikov added this to the 1.2.0 milestone Nov 28, 2016
@Mobe91 Mobe91 closed this as completed in 4f78c69 Dec 14, 2016
Mobe91 added a commit that referenced this issue Dec 14, 2016
@Mobe91
added testcase for #304
ddd0600
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Mobe91 Mobe91

Labels
kind: bug
Projects
None yet
Milestone
1.2.0
Development

No branches or pull requests
2 participants
@beikov @Mobe91