Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add null check for nullable onDateClickListener #53

Merged
merged 1 commit into from
Nov 17, 2017

Conversation

udaysrinath
Copy link
Collaborator

@JonatanSalas Please Review. Sorry missed this on my last change!

@udaysrinath
Copy link
Collaborator Author

udaysrinath commented Nov 17, 2017

This change alongside the previous change should be good together. @JonatanSalas Pretty minor change, if you can take a look and merge this and publish a new library, that would be awesome. And thanks again for all the help. Much appreciated!

@JonatanSalas
Copy link
Member

@udaysrinath okey I will take a look at it! :)

Copy link
Member

@JonatanSalas JonatanSalas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good because if onDateClickListener is not provided you prevent it from breaking.

@JonatanSalas JonatanSalas merged commit 1a1aa89 into BlackBoxVision:master Nov 17, 2017
@udaysrinath
Copy link
Collaborator Author

Thanks @JonatanSalas! Could you also update the library?

@JonatanSalas
Copy link
Member

Yes! I'm on it now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants